Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: use bare name string of new pk to compare with pk name when altering primary key #90992

Merged
merged 1 commit into from
Oct 31, 2022
Merged

release-22.2: sql: use bare name string of new pk to compare with pk name when altering primary key #90992

merged 1 commit into from
Oct 31, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 31, 2022 •
edited by chengxiong-ruan
Loading

Backport 1/1 commits from #90865 on behalf of @chengxiong-ruan.

/cc @cockroachdb/release

Fixes #90836

Release note (sql change): previously, the DROP CONSTRAINT, ADD CONSTRAINT in one trick to have a new primary key without moving old primary key to be a secondary index didn't work if the primary key name is a reserved SQL keyword. A constraint already exists error was returned. This patch fixed the bug, the trick now also works with primary key named as reserved keywords.

Release justification: low risk bug fix

@chengxiong-ruan
sql: use bare string to compare with pk name
de222e2 
Fixes #90836

Release note (sql change): previously, the `DROP CONSTRAINT, ADD CONSTRAINT`
in one trick to have a new primary key without moving old
primary key to be a secondary index didn't work if the primary
key name is a reserved SQL keyword. A `constraint already exists`
error was returned. This patch fixed the bug, the trick now
also works with primary key named as reserved keywords.
@blathers-crl blathers-crl bot requested a review from a team October 31, 2022 15:59
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-90865 branch from 1aec059 to de222e2 Compare October 31, 2022 15:59
@blathers-crl blathers-crl bot requested a review from postamar October 31, 2022 15:59
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 31, 2022 •
edited by ajwerner
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 31, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan chengxiong-ruan merged commit 3bafe9a into release-22.2 Oct 31, 2022
@chengxiong-ruan chengxiong-ruan deleted the blathers/backport-release-22.2-90865 branch October 31, 2022 18:28
ajwerner
ajwerner reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@cockroach-teamcity cockroach-teamcity mentioned this pull request Oct 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner left review comments

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@postamar postamar Awaiting requested review from postamar

Assignees

@chengxiong-ruan chengxiong-ruan

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @ajwerner @chengxiong-ruan