Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: diagrams: Diagrams job no longer fails when no diagrams change #90852

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 28, 2022

Backport 1/1 commits from #89753 on behalf of @nickvigilante.

/cc @cockroachdb/release


If there are PRs that don't affect the diagrams or their related files, the Publish SQL Grammar Diagrams job will fail, because git commit produces a non-zero exit code if there are no files changed in the working directory. This fixes that problem.

Release note: None

Fixes DOC-5642


Release justification: Non-production code changes

If there are PRs that don't affect the diagrams or their related files,
the Publish SQL Grammar Diagrams job will fail, because `git commit`
produces a non-zero exit code if there are no files changed in the
working directory. This fixes that problem.

Release note: None

Fixes DOC-5642
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 28, 2022 16:46
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-89753 branch from 4faeb53 to ffa1481 Compare October 28, 2022 16:46
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 28, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from nickvigilante and rail October 28, 2022 16:46
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 28, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@nickvigilante nickvigilante merged commit 64f2246 into release-22.2 Nov 28, 2022
@nickvigilante nickvigilante deleted the blathers/backport-release-22.2-89753 branch November 28, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants