Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistedsqlstats: skip logical_plan_sampling_for_explicit_txn #90744

Merged
merged 1 commit into from
Oct 27, 2022
Merged

persistedsqlstats: skip logical_plan_sampling_for_explicit_txn #90744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/sql/sqlstats/persistedsqlstats/datadriven_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/tests"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
"github.com/cockroachdb/cockroach/pkg/util/log"
Expand Down Expand Up @@ -151,6 +152,11 @@ func TestSQLStatsDataDriven(t *testing.T) {
dbName,
)
return fmt.Sprintf("%t, %t", previouslySampled, savePlanForStats)
case "skip":
var issue int
d.ScanArgs(t, "issue-num", &issue)
skip.WithIssue(t, issue)
return ""
}

return ""
Expand Down
3 changes: 3 additions & 0 deletions pkg/sql/sqlstats/persistedsqlstats/testdata/logical_plan_sampling_for_explicit_txn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
skip issue-num=89861
----

# This test checks the expected behavior of logical plan sampling.
# Given a tuple of (db_name, implicitTxn, fingerprint string), the logical plan
# is only sampled if and only if no logical plan has been sampled for the given
Expand Down