Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2.0: changefeedccl: job-level retry when error message is about draining #90718

Conversation

HonoreDB
Copy link
Contributor

@HonoreDB HonoreDB commented Oct 26, 2022

Backport 1/1 commits from #89913.

/cc @cockroachdb/release


See #https://github.com/cockroachlabs/support/issues/1839. The flow retryable error marker doesn't survive every path by which it can bubble up, so just look for the single word "draining" as false positives are much better than false negatives.

Fixes #89663

Release note (enterprise change): Fixed a bug that could cause changefeeds to fail during a rolling restart.

Release justification: Fixes a bug that could cause changefeeds to fail during a rolling restart (including if this version is being upgraded to).

See #https://github.com/cockroachlabs/support/issues/1839. The flow
retryable error marker doesn't survive every path by which it can
bubble up, so just look for the single word "draining" as false positives
are much better than false negatives.

Release note (enterprise change): Fixed a bug that could cause changefeeds to fail during a rolling restart.
@HonoreDB HonoreDB requested a review from a team as a code owner October 26, 2022 17:51
@HonoreDB HonoreDB requested review from ajwerner and removed request for a team October 26, 2022 17:51
@blathers-crl
Copy link

blathers-crl bot commented Oct 26, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@celiala
Copy link
Collaborator

celiala commented Feb 9, 2023

Closing this PR so I can delete the temporary "dot zero" branch.
This change was merged into the main release branch via #89913

@celiala celiala closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants