rules: some dep-rule changes #90544
Merged
rules: some dep-rule changes #90544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Xiang-Gu
force-pushed
the
remove-a-dep-rule
branch
from
7a1673e to
e8f6b39
Compare
This PR changed two dep-rules, both of which concerns the case when dropping a descriptor: - "descriptor drop right before dependent element removal": changed from SameStagePrecedence to Precedence. - "descriptor removal right before dependent element removal": removed Release note: None
Xiang-Gu
force-pushed
the
remove-a-dep-rule
branch
from
e8f6b39 to
2375804
Compare
ajwerner
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Reviewed 8 of 25 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed two dep-rules, both of which concerns the case when dropping a descriptor:
Epic: None
Release note: None