release-22.1: jobs,sql/importer: retry circuit breaker open errors #90432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #89354.
/cc @cockroachdb/release
We would like to retry circuit breaker open errors. In fact, jobs.IsPermanentBulkJobError already looks like it would return false for breaker open errors.
But, there are actually two circuit breaker packages we use:
Both define ErrBreakerOpen. IsPermanentBulkJobError would only catch errors from one of these packages. Now, we test for both.
As a result, ErrBreakerOpen errors emerging from the nodedialer will now be retried.
Fixes #89159
Fixes #85111
Fixes #81353
Fixes #91332
I may be being a bit optimistic that this will fully fixe those failures. Success of the job still requires that the retry of the job is successful.
Release note (bug fix): Fix bug that resulted in some retriable errors not being retried during IMPORT.
Release justification: Low-risk bug fix.