Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: configure ignore and block lists for 23.1 in roachtests #90377

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Oct 20, 2022

Configure ignore and block lists for 23.1 in roachtests.

Release note: None
Epic: RE-253

Configure ignore and block lists for 23.1 in roachtests.

Release note: None
@rhu713 rhu713 requested a review from celiala October 20, 2022 17:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@celiala celiala requested a review from rafiss October 20, 2022 17:29
@celiala
Copy link
Collaborator

celiala commented Oct 20, 2022

@rafiss - can you weigh-in when we should merge this PR? specifically, I know we caused some tests to fail the last time around (#80756) because we need to merge/do tasks in a specific order.

Thanks!

Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit itself :lgtm: (confirmed that these are all the files that need to be changed in ./pkg/cmd/roachtest/tests/_blocklist).

Will look to @rafiss for guidance regarding when to merge - thanks!

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

@rhu713
Copy link
Contributor Author

rhu713 commented Nov 2, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 3, 2022

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Nov 3, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 3, 2022

Build succeeded:

@craig craig bot merged commit d2171af into cockroachdb:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants