release-22.1: cluster-ui: add sql api request wrapper #90079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows DB Console to use the SQL over HTTP API from `/api/v2/sql/`. A new fetch wrapper providing the custom header necessary for the API and using content type JSON has been added. The clusterLocksApi components added in this commit use the above SQL api functions to query from the `crdb_internal.cluster_locks` table. Release note: None
|
This change is |
xinhaoz
changed the title
THardy98
reviewed
Oct 17, 2022
There was a problem hiding this comment.
Could you add release-22.1: ... to the PR title, to clarify that this is backport?
Took me an embarrassingly long time to realize that 👀
Reviewable status:
complete! 0 of 0 LGTMs obtained
xinhaoz
changed the title
THardy98
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 3 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:
This commit adds a helper function, `sqlResultsAreEmpty` to the sql api that determines whether there are execution results in the request response. Release note: None
Release note: None
xinhaoz
force-pushed
the
backport22.1-85080-88859
branch
from
4747cf4 to
f1094cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows DB Console to use the SQL over HTTP API from
/api/v2/sql/. A new fetch wrapper providing the custom headernecessary for the API and using content type JSON has been added.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release
Release justification: non-production code changes