Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2.0: kvserver: reduce log verbosity in lease score #90008

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 14, 2022

Backport 1/1 commits from #89996 on behalf of @kvoli.

/cc @cockroachdb/release


This patch reduces the logging verbosity in the allocator, in order to
avoid flooding distribution logs. Specifically, the lease transfer score
fn is called for every existing replica of a range. This in turn is
called for every range that is processed in the replicate queue, from
maybeTransferLease. As it logged as VInfo, it made up the majority of
logging. This patch changes the log verbosity to VEvent 2.

resolves: #89898

Release note: None


Release justification:

This patch reduces the logging verbosity in the allocator, in order to
avoid flooding distribution logs. Specifically, the lease transfer score
fn is called for every existing replica of a range. This in turn is
called for every range that is processed in the replicate queue, from
maybeTransferLease. As it logged as `VInfo`, it made up the majority of
logging. This patch changes the log verbosity to `VEvent` 2.

resolves: #89898

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 14, 2022 20:22
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2.0-89996 branch from 47c26ab to 4b98821 Compare October 14, 2022 20:22
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 14, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 14, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli merged commit 4c9713c into release-22.2.0 Oct 17, 2022
@kvoli kvoli deleted the blathers/backport-release-22.2.0-89996 branch October 17, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants