changefeedccl: cleanup deprecated pts handling #89975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Oct 14, 2022
samiskin
force-pushed
the
cleanup-deprecated-pts
branch
from
0e21e9d to
365a8b1
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
89975: changefeedccl: cleanup deprecated pts handling r=samiskin a=samiskin Resolves #89450 Going forward we no longer want customers to be able to turn off active protected timestamps, as we always want to remain resilient to low ttl tables. Release note (enterprise change): The changefeed.active_protected_timestamps.enabled cluster setting has been removed and is always treated as if it was true. Co-authored-by: Shiranka Miskin <[email protected]>
|
Build failed: |
|
Bump, this may have fallen through the cracks. I'm working on #89233 now which Yev tells me is contingent on this going in. |
|
Ah sorry forgot to get back to it, will rebase and bors by eod |
samiskin
force-pushed
the
cleanup-deprecated-pts
branch
from
365a8b1 to
000b87a
Compare
|
bors r+ |
|
bors r- |
|
Canceled. |
samiskin
force-pushed
the
cleanup-deprecated-pts
branch
from
000b87a to
05da337
Compare
Going forward we no longer want customers to be able to turn off active protected timestamps, as we always want to remain resilient to low ttl tables. Release note (enterprise change): The changefeed.active_protected_timestamps.enabled cluster setting has been removed and is always treated as if it was true.
samiskin
force-pushed
the
cleanup-deprecated-pts
branch
from
05da337 to
dce1723
Compare
|
Going to bors it your behalf. Happy thursday! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #89450
Going forward we no longer want customers to be able to turn off active protected timestamps, as we always want to remain resilient to low ttl tables.
Release note (enterprise change):
The changefeed.active_protected_timestamps.enabled cluster setting has been removed and is always treated as if it was true.