Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multitenant: fix failing distsql test #89905

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

cucaroach
Copy link
Contributor

Test was erroneously expecting a bundle in the bundle=off config.

Fixes: #89720

Release note: None

Test was erroneously expecting a bundle in the bundle=off config.

Fixes: cockroachdb#89720

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cucaroach cucaroach marked this pull request as ready for review October 13, 2022 12:01
@cucaroach cucaroach requested review from a team and mgartner October 13, 2022 12:01
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @mgartner)

@cucaroach
Copy link
Contributor Author

TFTRs!
bors r+

@craig
Copy link
Contributor

craig bot commented Oct 13, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 13, 2022

Build succeeded:

@craig craig bot merged commit 95733e7 into cockroachdb:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: multitenant/distsql/instances=20/bundle=off/timeout=0 failed
4 participants