Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: bump Pebble to b6b30d5f81ef #89839

Merged
merged 1 commit into from
Oct 12, 2022
Merged

vendor: bump Pebble to b6b30d5f81ef #89839

merged 1 commit into from
Oct 12, 2022

Conversation

nicktrav
Copy link
Collaborator 

b6b30d5f metamorphic/crossversion: use LinkOrCopy
5fdb3ead metric: expose pebble fsync latency with a callback
a4b203ef metrics: remove deprecated InternalIntervalMetrics method
f122ff49 tool: capture stdout / stderr

Release note: None.

Epic: None.

@nicktrav
vendor: bump Pebble to b6b30d5f81ef
10f2d25 
```
b6b30d5f metamorphic/crossversion: use LinkOrCopy
5fdb3ead metric: expose pebble fsync latency with a callback
a4b203ef metrics: remove deprecated InternalIntervalMetrics method
f122ff49 tool: capture stdout / stderr
```

Release note: None.

Epic: None.
@nicktrav nicktrav requested review from jbowens, coolcom200 and a team October 12, 2022 16:35
@nicktrav nicktrav requested a review from a team as a code owner October 12, 2022 16:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav
Copy link
Collaborator Author

I'm doing the Pebble bump separately in this PR, which will then unblock #89668.

@jbowens @coolcom200 - are there any other changes required when picking up the metrics changes? The binary built ok, so I assume y'all can do the wiring separately?

coolcom200
coolcom200 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@coolcom200 coolcom200 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jbowens @coolcom200 - are there any other changes required when picking up the metrics changes? The binary built ok, so I assume y'all can do the wiring separately?

This bump should have all the required changes for metrics. I made duplicate bump here #89834 but I'll close the PR.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jbowens)

@nicktrav
Copy link
Collaborator Author

Few flakes in CI, but given the required run is green I'm going to land this.

TFTR!

bors r=coolcom200

@coolcom200 coolcom200 mentioned this pull request Oct 12, 2022
Closed
@craig
Copy link
Contributor

craig bot commented Oct 12, 2022

Build succeeded:

@craig craig bot merged commit 5515ce7 into cockroachdb:master Oct 12, 2022
@nicktrav nicktrav deleted the nickt/pebble-master-b6b30d5f81ef branch October 12, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolcom200 coolcom200 coolcom200 approved these changes

@jbowens jbowens Awaiting requested review from jbowens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicktrav @cockroach-teamcity @coolcom200