kvserver: remove legacy snapshot and diff code #89813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pav-kv
commented
Oct 12, 2022
|
Let's hold off until we know what's up with 22.1 compatibility. I think we can still get rid of the diffs, because 22.1 will degrade gracefully if we omit them from the responses, but let's confirm. |
This commit removes the proto and code for RaftDataSnapshot. This type was used for reporting replica snapshots and computing diffs, but now this functionality has been removed in favor of storage checkpoints and offline tooling. Release note: None
erikgrinaker
approved these changes
Oct 17, 2022
pkg/kv/kvserver/helpers_test.go
Outdated
| func ChecksumRange( | ||
| ctx context.Context, desc roachpb.RangeDescriptor, snap storage.Reader, | ||
| ) ([]byte, error) { | ||
| var r *Replica // TODO(pavelkalinnikov): make this less ugly. |
There was a problem hiding this comment.
sha512() doesn't use the Replica receiver for anything, so we can just rename and export the function instead.
There was a problem hiding this comment.
Made it a stand-alone replicaSHA512 function, but not exported for now. It would require changing signature, or exporting the ad-hoc replicaHash type together with it.
There was a problem hiding this comment.
I'll see tomorrow if I can make this even cleaner, and will send a follow-up PR if so.
This function does not use the replica, so does not have to be a method. Epic: None Release note: None
|
bors r=erikgrinaker |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
90313: kvserver: cleanup replica checksum computation func r=erikgrinaker a=pavelkalinnikov This commit makes the replica checksum helper more convenient for tests, and simplifies the tests using it. Follows up on #89813 (comment) Epic: None Release note: None Co-authored-by: Pavel Kalinnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the proto and code for
RaftDataSnapshot. This type was used for reporting replica snapshots and computing diffs, but now this functionality has been removed in favor of storage checkpoints and offline tooling.Part of #21128
Epic: none
Release note: None