roachtest: add backup/mvcc-range-tombstones
#89761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
force-pushed
the
roachtest-backup-range-tombstones
branch
4 times, most recently
from
a6728c8 to
7378421
Compare
msbutler
reviewed
Oct 11, 2022
erikgrinaker
force-pushed
the
roachtest-backup-range-tombstones
branch
3 times, most recently
from
610946e to
8434265
Compare
This patch adds a roachtest to ensure backup and restore works as expected in the presence of MVCC range tombstones. It uses data from TPCH's order table, 16 GB across 8 CSV files. 1. Import half of the `tpch.orders` table (odd-numbered files). 2. Take fingerprint, time 'initial'. 3. Take a full database backup. 4. Import the other half (even-numbered files), but cancel the import and roll the data back using MVCC range tombstones. Done twice. 5. Take fingerprint, time 'canceled'. 6. Successfully import the other half. 7. Take fingerprint, time 'completed'. 8. Drop the table and wait for deletion with MVCC range tombstone. 9. Take an incremental database backup with revision history. It then does point-in-time restores of the database at times 'initial', 'canceled', 'completed', and the latest time, and compares the fingerprints to the original data. Release note: None
erikgrinaker
force-pushed
the
roachtest-backup-range-tombstones
branch
from
8434265 to
c32acf9
Compare
msbutler
approved these changes
Oct 12, 2022
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a roachtest to ensure backup and restore works as expected in the presence of MVCC range tombstones. It uses data from TPCH's order table, 16 GB across 8 CSV files.
tpch.orderstable (odd-numbered files).It then does point-in-time restores of the database at times 'initial', 'canceled', 'completed', and the latest time, and compares the fingerprints to the original data.
Resolves #89644.
Release note: None