-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: release-22.2: only check for introduced spans for online tables in restore #89688
release-22.1: release-22.2: only check for introduced spans for online tables in restore #89688
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
59872e0
to
5310031
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks good. The commit message could be cleaned up a bit, looks like you may have been going in two different directions with a sentence or two and they ended up a little mangled.
Can we add a test for this case?
5310031
to
73a4203
Compare
This small patch refines the introduced span corruption checker to ensure that only _online_ tables in a given backup are checked, as oppose to all tables included in manifest.Descriptors. This is necessary for checking cluster backups which currently include offline descriptors in manifest.Descriptors, which should not be checked, as they will not get restored. If the table was online at some point in the backup's interval, the check on each DescriptorChange that brought the table online already covers this case. Release note (bug fix): refnes a check conducted during restore that ensures that all previously offline tables were properly introduced. Release justification: bug fix
73a4203
to
d8b61b1
Compare
good callout. thanks for the proofread :) added a little test case as well. |
Backport 1/2 commits from #89102.
/cc @cockroachdb/release
This small patch refines the introduced span corruption checker to
ensure that only online tables in a given backup are checked, as oppose to
all tables included in manifest.Descriptors. This is necessary for checking
cluster backups which currently include offline descriptors in
manifest.Descriptors, which should not be checked, as they will not get
restored. If the table was online at some point in the backup's interval,
the check on each DescriptorChange that brought the table online already covers
this case.
Release note (bug fix): refnes a check conducted during restore that ensures
that all previously offline tables were properly introduced.
Release justification: bug fix