Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: remove ScanInterleavedIntents method #89441

Merged

Conversation

erikgrinaker
Copy link
Contributor

Resolves #89428.

upgrades: remove separated intents test data

This test no longer exists, only the datadriven test data.

Release note: None

kvserver: remove ScanInterleavedIntents method

This was used by the upgrade migration to separated intents in 21.2.
Interleaved intents no longer exist, and there are no callers in 22.2,
so this can safely be removed.

Release note: None

cli: remove interleaved intents from debug intent-count

Interleaved intents no longer exist. Only count separated intents.

Release note: None

This test no longer exists, only the datadriven test data.

Release note: None
This was used by the upgrade migration to separated intents in 21.2.
Interleaved intents no longer exist, and there are no callers in 22.2,
so this can safely be removed.

Release note: None
Interleaved intents no longer exist. Only count separated intents.

Release note: None
@erikgrinaker erikgrinaker requested review from itsbilal, sumeerbhola and a team October 5, 2022 20:46
@erikgrinaker erikgrinaker self-assigned this Oct 5, 2022
@erikgrinaker erikgrinaker requested a review from a team as a code owner October 5, 2022 20:46
@erikgrinaker erikgrinaker requested a review from a team October 5, 2022 20:46
@erikgrinaker erikgrinaker requested a review from a team as a code owner October 5, 2022 20:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
:lgtm:

Reviewed 1 of 1 files at r1, 13 of 13 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)

@erikgrinaker
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 6, 2022

Build succeeded:

@craig craig bot merged commit 2a1abc8 into cockroachdb:master Oct 6, 2022
@erikgrinaker erikgrinaker deleted the remove-scan-interleaved-intents branch October 30, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv: cleanup old code related to physically interleaved intents
3 participants