acceptance: support running acceptance tests on ARM64 #89232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
healthy-pod
force-pushed
the
acceptance-support-arm
branch
22 times, most recently
from
740ec1d to
a6c1bc2
Compare
otan
approved these changes
Oct 7, 2022
rafiss
reviewed
Oct 7, 2022
pkg/acceptance/compose_test.go
Outdated
| @@ -34,6 +35,7 @@ func TestComposeGSSPython(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestComposeFlyway(t *testing.T) { | |||
| skip.UnderArm64(t) | |||
There was a problem hiding this comment.
would be nice to have a comment or description here for why it's skipped.
There was a problem hiding this comment.
Agree, actually I initially skipped it because flyway:flyway6 image didn't support linux/arm64. Now I see that linux/arm64 is supported since 8.4.3 so I will update the image and unskip the test instead
This code change makes it possible to run acceptance tests on ARM64. Release note: None Epic: CRDB-1463
healthy-pod
force-pushed
the
acceptance-support-arm
branch
from
a6c1bc2 to
60a19e4
Compare
rafiss
approved these changes
Oct 10, 2022
|
bors r=otan,rafiss |
|
Build succeeded: |
|
blathers backport release-22.2 |
|
blathers backport release-22.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change makes it possible to run acceptance tests
on ARM64.
Release note: None
Epic: CRDB-1463