Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: admission: decrease log chattiness #89070

Merged
merged 1 commit into from
Sep 30, 2022
Merged

release-22.1: admission: decrease log chattiness #89070

merged 1 commit into from
Sep 30, 2022

Conversation

knz
Copy link
Contributor

@knz knz commented Sep 30, 2022

Backporting 1/1 commit from #89069.

Release justification: decrease splunk costs

@knz
admission: decrease log chattiness
49602a7 
The "CPULoad switching to period" was the 9th most voluminous log
event source in CC.

This commit reduces its verbosity.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Sep 30, 2022 •
edited by knz
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz mentioned this pull request Sep 30, 2022
Closed
24 tasks
@knz knz merged commit f416936 into cockroachdb:release-22.1 Sep 30, 2022
@knz knz deleted the 20220930-admission2 branch September 30, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

@sumeerbhola sumeerbhola Awaiting requested review from sumeerbhola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knz @cockroach-teamcity @irfansharif