Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: backupccl: decrease log chattiness #89065

Merged
merged 1 commit into from
Sep 30, 2022
Merged

release-22.1: backupccl: decrease log chattiness #89065

merged 1 commit into from
Sep 30, 2022

Conversation

knz
Copy link
Contributor

@knz knz commented Sep 30, 2022 •
edited
Loading

The "sending ExportRequest for span" log message was the 5th most voluminous log event source in CC.

This commit makes it less verbose, by importing a one-line change from another merged PR #84043 from v22.2.

Release justification: reduce splunk costs

@knz knz requested a review from a team as a code owner September 30, 2022 09:36
@knz knz requested review from rhu713 and removed request for a team September 30, 2022 09:36
@blathers-crl
Copy link

blathers-crl bot commented Sep 30, 2022 •
edited by knz
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz requested a review from adityamaru September 30, 2022 09:36
@knz knz mentioned this pull request Sep 30, 2022
Closed
24 tasks
stevendanna
stevendanna approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We could probably push the log interval further if needed. But 10s seems like a good starting place.

dt
dt approved these changes Sep 30, 2022
View reviewed changes
pkg/ccl/backupccl/backup_processor.go Outdated
@@ -331,6 +331,8 @@ func runBackupProcessor(
// *2). See #49798.
numSenders := int(kvserver.ExportRequestsLimit.Get(&clusterSettings.SV)) * 2

logExport := log.Every(10 * time.Second)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minutely would even be okay with me

@knz
backupccl: decrease log chattiness
6fe013b 
The "sending ExportRequest for span" log message was the 5th most
voluminous log event source in CC.

This commit makes it less verbose, by importing a one-line change from
another merged PR cockroachdb#84043 from v22.2.

Release note: None
@knz knz merged commit b6abff3 into cockroachdb:release-22.1 Sep 30, 2022
@knz knz deleted the 20220930-backup branch September 30, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

@dt dt dt approved these changes

@rhu713 rhu713 Awaiting requested review from rhu713 rhu713 is a code owner automatically assigned from cockroachdb/disaster-recovery

@adityamaru adityamaru Awaiting requested review from adityamaru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knz @cockroach-teamcity @dt @stevendanna