kvserver: decrease verbosity of replicate queue trace logging #89042
Conversation
|
This change is |
There was a problem hiding this comment.
This API feels unintuitive to me. So if what we're emitting is a warning, it'll show up in the main dev log, but if it's a regular info, it shows up elsewhere? What about warnings/errors (like this trace) that we do want to keep around, just not in the same log file?
Reviewable status:
complete! 0 of 0 LGTMs obtained
|
I believe it's rather that if it's a warning, it's emitted in its own log as well as in the main log, while if it's below warning, it will only be in its own log. I think that's how I'm supposed to be reading this thing: cockroach/pkg/cli/log_flags.go Lines 459 to 462 in 6850a6e It is also explicitly set up this way (for specific channels) in the test logging config. |
There was a problem hiding this comment.
Ack. Is there a way to wholly segment even warnings to just the distribution channel? As an observer, that feels like what I’d want. Perhaps this is a question for @lidorcarmel or @knz. This PR LGTM, thanks!
Reviewable status:
|
Perhaps worth eyeballing whether there are other possibly spammy warnings/errors that'd would benefit from this treatment. And filing an issue to revert them back to warnings/errors (easier to grep for in the dedicated log files), but properly segmented. |
While logging of traces on replicate queue errors was recently added, logging these traces at the `WARNING` level appears to be too high, causing noisy logs. This change decreases the verbosity of these logs to the `INFO` level. Release note: None
AlexTalks
force-pushed
the
rq_trace_at_info
branch
from
5655aa5 to
faeec7f
Compare
|
bors r+ |
|
Build succeeded: |
While logging of traces on replicate queue errors was recently added, logging these traces at the
WARNINGlevel appears to be too high, causing noisy logs. This change decreases the verbosity of these logs to theINFOlevel.Release note: None