Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: opt: fix error due to estimated row count must be non-zero #88955

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

rytaft
Copy link
Collaborator

@rytaft rytaft commented Sep 28, 2022

Backport 1/1 commits from #88494.

/cc @cockroachdb/release


This commit fixes an error in the statistics code that was caused by integer overflow when calculating the distinct count.

Fixes #85499

Release note (bug fix): Fixed a rare internal error that could occur during planning when a predicate included values close to the maximum or minimum int64 value. The error, "estimated row count must be non-zero", has now been fixed.


Release justification: low risk fix for internal error

@rytaft rytaft requested review from michae2, DrewKimball and a team September 28, 2022 20:01
@rytaft rytaft requested review from a team as code owners September 28, 2022 20:02
@blathers-crl
Copy link

blathers-crl bot commented Sep 28, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit fixes an error in the statistics code that was caused
by integer overflow when calculating the distinct count.

Fixes cockroachdb#85499

Release note (bug fix): Fixed a rare internal error that could occur
during planning when a predicate included values close to the maximum
or minimum int64 value. The error, "estimated row count must be non-zero",
has now been fixed.
@rytaft rytaft merged commit dbc0010 into cockroachdb:release-21.2 Sep 29, 2022
@rytaft rytaft deleted the backport21.2-88494 branch September 29, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants