release-21.2: opt: don't mark st_makeline and st_extend as non-null #88954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #86722 on behalf of @DrewKimball.
/cc @cockroachdb/release
st_makeline
can take arguments of typePOINT
,MULTIPOINT
, andLINESTRING
. Other types cause it to return null (even if the input isnon-null). Similarly,
st_extent
returns null when the input geometry isnon-null, but empty.
This commit prevents these two aggregate functions from being marked as
non-null, since doing so can lead to incorrect results in the cases
mentioned above.
Fixes #84957
Release justification: low-risk fix to bug that can lead to incorrect results
Release note (bug fix): Fixed a longstanding bug that could cause the optimizer
to produce an incorrect plan when aggregate functions
st_makeline
orst_extent
were called with invalid-type and empty inputs respectively.