sql: add tracing spans for each statement executed within a UDF #88929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
pkg/sql/routine.go line 72 at r1 (raw file):
for i := 0; i < expr.NumStmts; i++ { if err := func() error { opName := "udf-stmt-" + strconv.Itoa(i)
nit: RoutineExpr has name field - it'd be good to include that in the opName here too.
mgartner
force-pushed
the
udf-tracing
branch
from
bd8a316 to
069edb3
Compare
mgartner
commented
Sep 28, 2022
There was a problem hiding this comment.
Reviewable status:
pkg/sql/routine.go line 72 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit:
RoutineExprhasnamefield - it'd be good to include that in theopNamehere too.
Done.
This commit creates a separate tracing span for each statement executed during evaluation of a UDF. Release note: None
mgartner
force-pushed
the
udf-tracing
branch
from
069edb3 to
987d004
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
|
blathers backport 22.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a separate tracing span for each statement executed during evaluation of a UDF.
Release note: None