Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: Fix array encoding avro bug. #88814

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

miretskiy
Copy link
Contributor

Fix latent array avro encoding bug where previously allocated memo array might contain 'nil' element, while the code assumed that the element must always be a map.

Release note: none.

Fix latent array avro encoding bug where previously allocated
memo array might contain 'nil' element, while the code assumed
that the element must always be a map.

Release note: none.
@miretskiy miretskiy requested a review from a team as a code owner September 27, 2022 14:56
@miretskiy miretskiy requested review from HonoreDB and removed request for a team September 27, 2022 14:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@HonoreDB HonoreDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)

@miretskiy
Copy link
Contributor Author

Fixes #88816

@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 27, 2022

Build succeeded:

@craig craig bot merged commit ae38d90 into cockroachdb:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants