-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: storage: Fix GCBytesAge in CheckSSTConflicts with range keys #88783
release-22.2: storage: Fix GCBytesAge in CheckSSTConflicts with range keys #88783
Conversation
066d4e4
to
442a895
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport freeze went into effect yesterday, so I'm afraid this will have to wait until 22.2.1. We're not currently expecting SSTs with CheckSSTConflicts
to contain range keys anyway, so that seems fine, and if we were to start using them in mixed 23.1/22.2.0 clusters then a stats mismatch isn't the end of the world.
Reminder: it has been 3 weeks please merge or close your backport! |
I think we can get this merged now @itsbilal. |
Reminder: it has been 3 weeks please merge or close your backport! |
I'm gonna go ahead and merge this. |
Backport 1/1 commits from #88578 on behalf of @itsbilal.
/cc @cockroachdb/release
Change #87303 fixed GCBytesAge in
CheckSSTConflicts
for points, but not for range keys. This change fixes it for range keys too, by ensuring the changes to statsDiff happen at the right timestamp using statsDiff.AgeTo.Fixes #82920.
Release note: None.
Release justification: fixes bug in MVCC stats update.