sqlliveness: change heartbeat timeouts to be a fraction of TTL #88764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the heartbeat timeouts were being set as the length of the heartbeat. This can cause issues when there is longer latency in the system and caused flaky tests. By making the heartbeat timout a fraction of the TTL, we are able to avoid timing out too early and also ensure that we can retry at least once before the seession expiry. Ran test with `--stress` to verify it doesn't flake: ``` 2559 runs so far, 0 failures, over 5m0s ``` Resolves: cockroachdb#88743 Release note: None
|
This change is |
ajwerner
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi)
|
bors r=ajwerner |
|
Build succeeded: |
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the heartbeat timeouts were being set as the length of the heartbeat. This can cause issues when there is longer latency in the system and caused flaky tests.
By making the heartbeat timout a fraction of the TTL, we are able to avoid timing out too early and also ensure that we can retry at least once before the seession expiry.
Ran test with
--stressto verify it doesn't flake:Resolves: #88743
Release note: None