Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: *: downgrade grpc to v1.46.0 #88749

Merged

Conversation

erikgrinaker
Copy link
Contributor

Backport 1/1 commits from #88745.

/cc @cockroachdb/release


This downgrades gRPC from v1.49.0 back down to v1.46.0, due to several
test failures suspected to be caused by the upgrade (in particular
kv/splits/nodes=3/quiesce=*).

Resolves #88678.
Resolves #88658.

Release note: None

Release justification: fixes cluster stability issues.

@erikgrinaker erikgrinaker requested review from nvanbenschoten and a team September 26, 2022 18:46
@erikgrinaker erikgrinaker self-assigned this Sep 26, 2022
@erikgrinaker erikgrinaker requested a review from a team as a code owner September 26, 2022 18:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker changed the title *: downgrade grpc to v1.46.0 release-22.2: *: downgrade grpc to v1.46.0 Sep 26, 2022
Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikgrinaker
Copy link
Contributor Author

Both CI builds had TestLeasePreferencesDuringOutage fail. However, that's been seen to flake elsewhere too, and gRPC 1.46 is known to work. No local stress failures. Rerunning.

@erikgrinaker erikgrinaker force-pushed the revert-grpc-22.2 branch 4 times, most recently from 9dd03c0 to 3af73ad Compare September 26, 2022 21:51
@erikgrinaker
Copy link
Contributor Author

This is taking a while between test flakes and vendor conflicts. I'm heading to bed -- feel free to merge this on green, otherwise I'll merge tomorrow.

This downgrades gRPC from v1.49.0 back down to v1.46.0, due to several
test failures suspected to be caused by the upgrade (in particular
`kv/splits/nodes=3/quiesce=*`).

Release note: None
@erikgrinaker erikgrinaker merged commit 86e44aa into cockroachdb:release-22.2 Sep 27, 2022
@erikgrinaker erikgrinaker deleted the revert-grpc-22.2 branch December 5, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants