Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: opt: project required ordering for EXPLAIN to input columns #88686

Merged
merged 1 commit into from
Oct 5, 2022
Merged

release-22.1: opt: project required ordering for EXPLAIN to input columns #88686

merged 1 commit into from
Oct 5, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 25, 2022 •
edited by DrewKimball
Loading

Backport 1/1 commits from #88441 on behalf of @DrewKimball.

/cc @cockroachdb/release

Previously, EXPLAIN operators could require an ordering on non-output columns from their enclosed expression, which causes a panic. This could happen after column-pruning rules fired. This commit modifies the order-building logic to project the ordering required of the child of an EXPLAIN operator to only reference output columns.

Fixes #88037

Release note (bug fix): Fixed a longstanding bug that could cause a panic when running a query with EXPLAIN that attempts to order on a non-output column.

Release justification: low-risk bug fix for optimizer panic

@DrewKimball
opt: project required ordering for EXPLAIN to input columns
bcd9fd1 
Previously, `EXPLAIN` operators could require an ordering on non-output
columns from their enclosed expression, which causes a panic. This
could happen after column-pruning rules fired. This commit modifies the
order-building logic to project the ordering required of the child of
an `EXPLAIN` operator to only reference output columns.

Fixes #88037

Release note (bug fix): Fixed a longstanding bug that could cause
a panic when running a query with `EXPLAIN` that attempts to order
on a non-output column.
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 25, 2022 19:20
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-88441 branch from e5cc6c9 to bcd9fd1 Compare September 25, 2022 19:20
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 25, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 25, 2022 •
edited by DrewKimball
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

yuzefovich
yuzefovich approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @mgartner)

@DrewKimball
Copy link
Collaborator

TFTR

@DrewKimball DrewKimball merged commit e6f9f8b into release-22.1 Oct 5, 2022
@DrewKimball DrewKimball deleted the blathers/backport-release-22.1-88441 branch October 5, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

@DrewKimball DrewKimball Awaiting requested review from DrewKimball

@mgartner mgartner Awaiting requested review from mgartner

Assignees

@DrewKimball DrewKimball

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @DrewKimball @yuzefovich