-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: kvserver/reports: replication_constraint_stats use voter constraints #88662
release-22.1: kvserver/reports: replication_constraint_stats use voter constraints #88662
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
6893719
to
a15897a
Compare
Previously replication_constraint_stats were using zone constraints regardless of the fact that num_voters and a separate voter constraints were provided. This was causing report to have violations because range had less voters than replicas, but still were trying to check if we have as many voters as full replica constraints. This was causing ambiguity in reports as there were no violation and no way to figure out which constraint is being violated. This patch changes report to use voter constraints if they are provided or use voters and non voters if voter count is configured lower than replica count, but voter constraints are not provided. Release note (bug fix): table system.replication_constraint_stats is not showing erroneous voter contraint violations when num_voters is configured. Release justification: bugfix to an issue which also needs backporting.
a15897a
to
83122f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @aliher1911)
@andreimatei can you "approve" the review pls as merge is blocked until it is properly marked |
Backport 1/1 commits from #84727.
/cc @cockroachdb/release
Previously replication_constraint_stats were using zone constraints regardless
of the fact that num_voters and a separate voter constraints were provided.
This was causing report to have violations because range had less voters than
replicas, but still were trying to check if we have as many voters as
full replica constraints.
This was causing ambiguity in reports as there were no violation and no way
to figure out which constraint is being violated.
This patch changes report to use voter constraints if they are provided or
use voters and non voters if voter count is configured lower than replica
count, but voter constraints are not provided.
Release note (bug fix): table system.replication_constraint_stats is not
showing erroneous voter contraint violations when num_voters is configured.
Release justification: bugfix to an issue which also needs backporting.
Fixes #84695