*: Add fast gzip compression library. #88632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
HonoreDB
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)
miretskiy
force-pushed
the
3pgzip
branch
6 times, most recently
from
eb1d2e1 to
fa1cf22
Compare
srosenberg
added
the
branch-release-22.2
Add https://github.com/klauspost/pgzip fast gzip compression library. Addresses cockroachdb#88585 Release notes: None
|
bors r+ |
|
Build succeeded: |
srosenberg
added
backport-22.2.x
and removed
branch-release-22.2
|
blathers backport 22.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 688430b to blathers/backport-release-22.2-88632: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
craig bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
89524: backupccl: use klauspost gzip library r=benbardin a=benbardin Expect some degree of speedup in manifest reading/writing, as in #88632. Release note: None 89903: sql: make NOTHING and INDEX non-reserved keywords r=rafiss a=knz Fixes #69420. Release note (bug fix): It is now possible again to create tables, views, columns, etc with the name `nothing` (e.g. `CREATE TABLE nothing...`) without having to quote the name, like in PostgreSQL. This bug was introduced in CockroachDB v2.0. Release note (bug fix): It is now possible again to create tables, views, columns, etc with the name `index` (e.g. `CREATE TABLE index...`) without having to quote the name, like in PostgreSQL. This bug was introduced in CockroachDB v1.0. 90000: workload/kv: fix --splits r=ajwerner a=kvoli Previously the `--splits` flag would generate splits assuming the kv workload would always access keys in `[MinInt64, MaxInt64)`. However, it was only true for the default uniform hash key generator. While it was disabled for `--sequential` and `--zipfian` generates keys in `[0, MaxInt64)`. The previous `--split` flag also resulted in an integer overflow when `--cycle-length` was greater than 0, only generating splits in `[MinInt64, 0)`. This patch resolves the overflow issue. This patch enables splits for `--sequential` and adjusts the `--splits` logic to equally partition the keyspace, according to the access distribution. The valid range for each is shown below. uniform `[MinInt64, MaxInt64)` sequential `[0, --cycle-length)` zipfian `[0, MaxInt64)` resolves #82906 Release note (cli change): In the kv workload enable `--splits` with the `--sequential` flag and adjust splitting to uniformly partition the keyspace. Co-authored-by: Ben Bardin <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Austen McClernon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add https://github.com/klauspost/pgzip fast gzip
compression library.
Addresses #88585
Release notes: None