sql/opt: fix negative annotation caching for RegionConfig #88515
Conversation
|
This change is |
There was a problem hiding this comment.
Nice find! LGTM, but I'll defer to @msirek for approval.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @msirek)
-- commits line 6 at r1:
nit: I believe it was introduced in 1540ea8 during 22.2 cycle, so no stable release with this bug and the release note is not needed.
pkg/sql/opt/table_meta.go line 448 at r1 (raw file):
// GetRegionsInDatabase finds the full set of regions in the multiregion // database owning the table described by `tm`, or returns ok=false if not
nit: s/ok/hasRegionNames/.
There was a problem hiding this comment.
Thanks for fixing this!
Reviewable status:
Fixes cockroachdb#88511 Release note: None
ajwerner
force-pushed
the
ajwerner/fix-negative-region-cache
branch
from
f42e0ee to
48529af
Compare
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: I believe it was introduced in 1540ea8 during 22.2 cycle, so no stable release with this bug and the release note is not needed.
Ack, gotta get that backport merged soon 🤞
pkg/sql/opt/table_meta.go line 448 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit:
s/ok/hasRegionNames/.
Done.
|
Build succeeded: |
Fixes #88511
Release note (performance improvement): Fixed minor bug where negative caching of region configuration information could result in extra work when use a database that is not configured for multi-region.