-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: add storage time-series metrics for level size and score #88504
Conversation
994a384
to
56c8d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jbowens and @nicktrav)
pkg/util/metric/metric.proto
line 54 at r1 (raw file):
// UNITLESS expresses that the metric's measurement does not have units (e.g. // a score). UNITLESS = 9;
Is adding an enum value here sufficient, or does it need some plumbing elsewhere too?
btw, COUNT does not have units either, and we seem to use it both for gauge and cumulative.
Is the assumption that COUNT is for integers while this UNITLESS value should be used for floats? I think it's worth clarifying via code comment how one should decide between COUNT and UNITLESS.
Currently, the only way to infer the compaction score and heuristics is to use the LSM printout from the logs (emitted once every ten minutes), or to call the `/debug/lsm` endpoint manually, and track values over time. This makes it difficult to debug issues retroactively. Add two new sets of per-LSM-level time-series metrics for level size and level score. These new metrics have names of the form `storage.$LEVEL-level-{size,score}`. Closes cockroachdb#88415. Release note (ops change): Adds two new sets of per-LSM-level time-series metrics, one for level size and another for level score. These metrics are of the form `storage.$LEVEL-level-{size,score}`.
56c8d1b
to
d41cce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @jbowens and @sumeerbhola)
pkg/util/metric/metric.proto
line 54 at r1 (raw file):
COUNT does not have units either, and we seem to use it both for gauge and cumulative.
Reverted to just use COUNT
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @sumeerbhola)
TFTRs! bors r=sumeerbhola,jbowens |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from d41cce0 to blathers/backport-release-22.1-88504: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Currently, the only way to infer the compaction score and heuristics is to use the LSM printout from the logs (emitted once every ten minutes), or to call the
/debug/lsm
endpoint manually, and track values over time. This makes it difficult to debug issues retroactively.Add two new sets of per-LSM-level time-series metrics for level size and level score. These new metrics have names of the form
storage.$LEVEL-level-{size,score}
.Closes #88415.
Release note (ops change): Adds two new sets of per-LSM-level time-series metrics, one for level size and another for level score. These metrics are of the form
storage.$LEVEL-level-{size,score}
.