{bazci,dev}: send build events to beaver hub

[healthy-pod]

This code change lets bazci and dev send build events to beaver hub so
we can start collecting data about builds in CI and locally.

Release note: None
Epic: CRDB-8350

[cockroach-teamcity]

This change is 

[healthy-pod]

This is now ready for review but shouldn't be merged until beaver hub PR is merged and applied. Only change needed here is updating beaverHubServerEndpoint once we have it.

[rickystewart]

I think the bazci change will conflict with #89845, which will stop bazci from producing a --build_event_binary_file. Can you rebase atop that change and make sure it's still working?

[rickystewart]

Hmm, I would rather you just put this in a temporary directory rather than right in the workspace.

[healthy-pod]

Right but how can we pass the tempdir name back to main where we call sendBepDataToBeaverHubIfNeeded? I see three options:

• keep it like it is
• mutable global variable
• call sendBepDataToBeaverHubIfNeeded at the end of dev.build and dev.test, while still not failing or returning any beaver hub errors (just logging them and returning the build/test err if any)

[rickystewart]

I don't understand why it's so important the sendBepDataToBeaverHubIfNeeded call is all the way up in main(). Seems like the calls can just be in build() or test(), given those are the only two places where we produce these files.

[healthy-pod]

So having a temporary dir sounds good to me and I made the change but we have an issue. How can we deal with this dynamic output from testcases?

[healthy-pod]

I added a --data-driven-test flag, ready for another look now.

[rickystewart]

Instead of adding a new flag, one thing you might try is making a global variable to mark whether this is a test. IIRC we used to have this logic in dev but it was removed due to being no longer needed? Anyway, here's what you can do:

1. In some file (e.g. util.go), add var isTesting bool as a global variable. This will default to false for all uses in dev.
2. Update to refer to isTesting instead of dataDrivenTestIgnoreTemporaryPaths
3. In pkg/cmd/dev/datadriven_test.go, add func init() { isTesting = true }. This will ensure that the variable is set only for test builds.

This way you get the behavior during tests and you don't have to update anything unnecessary in the datadriven test files.

Another option is depending on pkg/util/buildutil and checking buildutil.CrdbTestBuild, although you need an extra dependency. It's a tiny dependency so this is probably not a huge deal for dev.

[healthy-pod]

Another option is depending on pkg/util/buildutil and checking buildutil.CrdbTestBuild, although you need an extra dependency. It's a tiny dependency so this is probably not a huge deal for dev.

Nice, I went with this one.

[rickystewart]

Nit: Consider not creating this directory at all (and not cleaning it up) if buildutil.CrdbTestBuild is set.

[rickystewart]

I think you'll have to update the disallowed_imports_test in pkg/cmd/dev/BUILD.bazel to allow //pkg/util/buildutil, BTW.

[healthy-pod]

I think you'll have to update the disallowed_imports_test in pkg/cmd/dev/BUILD.bazel to allow //pkg/util/buildutil, BTW.

Looks like it is already allowed on master.

Edit: oh no it's not nvm..

[healthy-pod]

TFTR!

bors r=rickystewart

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)