release-22.2: backupccl: tenants should be restored in their correct state #88157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #87931 on behalf of @adityamaru.
/cc @cockroachdb/release
Previously, all backed up tenants were unconditionally moved through an
ADD
and thenACTIVE
state during a cluster/tenant restore. This behaviour appears incorrect. If the tenant was backed up in and adding or dropped state then it should be restored in the same state as well.This change only moves
ACTIVE
backed up tenants through anADD
and thenACTIVE
state thereby fixing this bug.Fixes: #87915
Release note (bug fix): Cluster and tenant restores of dropped or adding tenants would incorrectly activate those tenants
during restore.
Release justification: high-impact bug fix that prevents dropped or adding tenants from being activated after restore.