Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix current_setting(..., true) for custom options #88139

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Sep 19, 2022

Release note (bug fix): The current_setting builtin function now properly does not result in an error when checking a custom session setting that does not exist and the missing_ok argument is true.

Release note (bug fix): The `current_setting` builtin function now
properly does not result in an error when checking a custom session
setting that does not exist and the `missing_ok` argument is true.
@rafiss rafiss requested review from ZhouXing19 and a team September 19, 2022 15:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@ZhouXing19 ZhouXing19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rafiss
Copy link
Collaborator Author

rafiss commented Sep 19, 2022

tftr!

bors r=ZhouXing19

@craig
Copy link
Contributor

craig bot commented Sep 19, 2022

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Sep 19, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 888bf2b to blathers/backport-release-21.2-88139: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from 888bf2b to blathers/backport-release-22.1-88139: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants