Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: roachtest: add 4s of sleep after restart when upgrading nodes #87882

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 12, 2022

Backport 1/1 commits from #87715 on behalf of @yuzefovich.

/cc @cockroachdb/release


We have seen cases where a transient error could occur when a newly-upgraded node serves as a gateway for a distributed query due to remote nodes not being able to dial back to the gateway for some reason (investigation of it is tracked in #87634). For now, we're papering over these flakes by 4 second sleep.

Addresses: #87104.

Release note: None


Release justification: test-only change.

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-87715 branch from 8a8c59b to b551970 Compare September 12, 2022 21:54
@blathers-crl blathers-crl bot requested review from smg260 and tbg September 12, 2022 21:54
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 12, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 12, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg
Copy link
Member

tbg commented Sep 15, 2022

LGTM I think you technically need a backport request on slack, @erikgrinaker can sign off on that.

We have seen cases where a transient error could occur when a
newly-upgraded node serves as a gateway for a distributed query due
to remote nodes not being able to dial back to the gateway for some
reason (investigation of it is tracked in #87634). For now, we're
papering over these flakes by 4 second sleep.

Release note: None
@yuzefovich yuzefovich force-pushed the blathers/backport-release-22.2-87715 branch from b551970 to 46a2ad5 Compare September 15, 2022 18:59
@yuzefovich
Copy link
Member

Rebased on top of latest 22.2 and requested the approval from Erik on slack, will merge once the CI is green.

@yuzefovich yuzefovich merged commit c19e0d7 into release-22.2 Sep 15, 2022
@yuzefovich yuzefovich deleted the blathers/backport-release-22.2-87715 branch September 15, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants