Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvevent: Avoid busy loop during out of quota #87737

Merged
merged 1 commit into from
Sep 10, 2022
Merged

kvevent: Avoid busy loop during out of quota #87737

merged 1 commit into from
Sep 10, 2022

Conversation

miretskiy
Copy link
Contributor

Previous PR #87464 erroneously removed code to ensure that consumer is notified about out of quota events once. Rectify this issue.

Release Justification: bug fix
Release note: None

kvevent: Avoid busy loop during out of quota
28a5a08 
Previous PR cockroachdb#87464 erroneously removed code to ensure
that consumer is notified about out of quota events
once.  Rectify this issue.

Release Justification: bug fix
Release note: None
@miretskiy miretskiy requested a review from a team as a code owner September 9, 2022 19:29
@miretskiy miretskiy requested review from HonoreDB and removed request for a team September 9, 2022 19:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy
Copy link
Contributor Author

Once backported to 22.1, Fixes #87680

HonoreDB
HonoreDB approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@HonoreDB HonoreDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jayshrivastava)

@HonoreDB
Copy link
Contributor

HonoreDB commented Sep 9, 2022

LGTM--reminder to myself or whoever reviews the backport to make sure the mutex is locking and unlocking in the right place.

@ajwerner ajwerner added the branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 label Sep 9, 2022
ajwerner
ajwerner approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We have to figure out how to test this

@miretskiy miretskiy mentioned this pull request Sep 9, 2022
Open
@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 9, 2022

Build failed:

@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 10, 2022

Build succeeded:

@craig craig bot merged commit 389661e into cockroachdb:master Sep 10, 2022
@blathers-crl
Copy link

blathers-crl bot commented Sep 10, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from 28a5a08 to blathers/backport-release-22.1-87737: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.

error creating merge commit from 28a5a08 to blathers/backport-release-22.2-87737: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

This was referenced Sep 10, 2022
Merged
Merged
Closed
Closed
@miretskiy miretskiy mentioned this pull request Oct 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayshrivastava jayshrivastava jayshrivastava approved these changes

@ajwerner ajwerner ajwerner approved these changes

@HonoreDB HonoreDB HonoreDB approved these changes

Assignees
No one assigned
Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miretskiy @cockroach-teamcity @HonoreDB @ajwerner @jayshrivastava