Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add 4s of sleep after restart when upgrading nodes #87715

Merged
merged 1 commit into from
Sep 12, 2022
Merged

roachtest: add 4s of sleep after restart when upgrading nodes #87715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/cmd/roachtest/tests/versionupgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,15 @@ func upgradeNodes(
settings := install.MakeClusterSettings(install.BinaryOption(binary))
settings.Env = append(settings.Env, "COCKROACH_UPGRADE_TO_DEV_VERSION=true")
c.Start(ctx, t.L(), startOpts, settings, c.Node(node))

// We have seen cases where a transient error could occur when this
// newly upgraded node serves as a gateway for a distributed query due
// to remote nodes not being able to dial back to the gateway for some
// reason (investigation of it is tracked in #87634). For now, we're
// papering over these flakes by this sleep. For more context, see
// #87104.
// TODO(yuzefovich): remove this sleep once #87634 is fixed.
time.Sleep(4 * time.Second)
}
}

Expand Down