kvserver: remove ProposeEmptyCommand #87710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
approved these changes
Sep 12, 2022
|
Going to gate this behind #88985. That PR also picks up a fix that makes sure that the leader's |
We should no longer need it. Also, it introduces the complication of "empty but ID'ed raft commands", which is annoying. We could probably change this to propose a truly `nil` command (mimicking what raft does internally) but it is better to avoid this problem altogether. If there truly is a case in which we need to nudge raft, it likely also exists outside of the `splitDelayHelper`, and the sooner we find out about it the better. Extracted from cockroachdb#76126. Release note: None
tbg
force-pushed
the
remove-prop-empty-cmd
branch
from
cb6b51a to
28b2350
Compare
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should no longer need it. Also, it introduces the complication
of "empty but ID'ed raft commands", which is annoying. We could
probably change this to propose a truly
nilcommand (mimickingwhat raft does internally) but it is better to avoid this problem
altogether.
If there truly is a case in which we need to nudge raft, it likely
also exists outside of the
splitDelayHelper, and the sooner wefind out about it the better.
Extracted from #76126.
Epic: None
Release note: None