test: prevent auto comments on test failure issues with X-noreuse label #87708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM Just wanted to point out an alternative workflow: don't use test failure threads to track bugs. Instead, file a separate issue for the bug and mention the comment with the test failure in it. I think I personally tend to follow that strategy, since roachtest issues are never really that clean a source. For example, the interesting bug might be the fifth test failure in an existing issue. I'm fine with this though, after all nobody's forced to do it that way. |
tbg
approved these changes
Sep 12, 2022
herkolategan
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler)
Currently, when our nightly test suite detects a test failure, it either opens a new github issue or comments on an existing one with a title that roughly matches the failed test's name, using github search. Sometimes it's nice that fresh failures get posted to the existing issue, but in other situations, an engineering team may use the original test failure issue to track a specific bug. So, if the nightly CI build continues to comment on the original issue, perhaps due to a different failure mode, it becomes harder for the eng team to track different failure modes for a given test. Further, even if the eng team renamed part of the issue name to prevent automatic commenting, github search may still match and comment on the renamed issue. This patch prevents test failures from getting automatically posted to existing github issues with the new X-noreuse label. Release note: None
msbutler
force-pushed
the
butler-roachtest-reuse
branch
from
a1bb0fb to
fa899d3
Compare
|
TFTRs!! bors r= tbg, herkolategan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when our nightly test suite detects a test failure, it either opens a new github issue or comments on an existing one with a title that roughly matches the failed test's name, using github search. Sometimes it's nice that fresh failures get posted to the existing issue, but in other situations, an engineering team may use the original test failure issue to track a specific bug. So, if the nightly CI build continues to comment on the original issue, perhaps due to a different failure mode, it becomes harder for the eng team to track different failure modes for a given test. Further, even if the eng team renamed part of the issue name to prevent automatic commenting, github search may still match and comment on the renamed issue.
This patch prevents test failures from getting automatically posted to existing github issues with the new X-noreuse label.
Release note: None