colbuilder: fix planning with no aggregate funcs in non-scalar context #87451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in a case when the aggregator doesn't have any aggregate functions to evaluate, we would replace it with a special "fixed num tuples" operator, with the number of tuples always set to 1. But that is only correct if the aggregator is in scalar context - in the non-scalar context we should return no tuples. The bug has been present since forever, and I couldn't come up with a repro without disabling some of the optimizer rules, so it seems unlikely to occur in production, thus, there is no release note. Release justification: bug fix. Release note: None
|
This change is |
mgartner
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Nice! Thanks!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msirek)
|
TFTR! bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 6543c8f to blathers/backport-release-21.2-87451: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This was referenced Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in a case when the aggregator doesn't have any aggregate functions to evaluate, we would replace it with a special "fixed num tuples" operator, with the number of tuples always set to 1. But that is only correct if the aggregator is in scalar context - in the non-scalar context we should return no tuples. The bug has been present since forever, and I couldn't come up with a repro without disabling some of the optimizer rules, so it seems unlikely to occur in production, thus, there is no release note.
Fixes: #87434.
Release justification: bug fix.
Release note: None