Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: parse sequence name instead of using name identifier directly #87310

Merged

Conversation

chengxiong-ruan
Copy link
Contributor

Previously, we use the sequence name identifier directly when building
a function in optbuilder if a function expression use any sequences.
This does work when sequence name string is qualifed because sequence
name cannot be found. We need to parse the name string into a table
name instead.

Release note: None.
Release justification: low risk bug fix.

@chengxiong-ruan chengxiong-ruan requested a review from a team as a code owner September 1, 2022 20:58
@chengxiong-ruan chengxiong-ruan requested a review from a team September 1, 2022 20:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add some more tests with names in double quotes inside the string?

Previously, we use the sequence name identifier directly when building
a function in optbuilder if a function expression use any sequences.
This does work when sequence name string is qualifed because sequence
name cannot be found. We need to parse the name string into a table
name instead.

Release note: None.
Release justification: low risk bug fix.
@chengxiong-ruan chengxiong-ruan force-pushed the parse-seq-name-instead-of-using-id branch from 7cee33a to 2fbca6a Compare September 6, 2022 14:52
@chengxiong-ruan
Copy link
Contributor Author

chengxiong-ruan commented Sep 6, 2022

add some more tests with names in double quotes inside the string?

Good point, added.

@chengxiong-ruan
Copy link
Contributor Author

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Sep 6, 2022

Build succeeded:

@craig craig bot merged commit 0197ada into cockroachdb:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants