generate-logictest: add test timeout to BUILD files template #87299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
requested changes
Sep 1, 2022
| @@ -249,6 +249,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_test") | |||
| go_test( | |||
| name = "{{ .TestRuleName }}_test", | |||
| size = "enormous", | |||
| args = ["-test.timeout=3595s"], | |||
There was a problem hiding this comment.
Indentation looks wrong?
In cockroachdb#86363, we added a test.timeout arg to all go_test targets. When generate-logictest runs out of `bazel-generate.sh`, logic tests build files are re-created based on the template that was missing the `test.timeout` arg. This patch updates the template to include a test timeout. Release justification: Non-production code changes Release note: None
healthy-pod
force-pushed
the
fix-logictests-timeout
branch
from
083919c to
b75d2ee
Compare
rickystewart
approved these changes
Sep 1, 2022
|
bors r=rickystewart |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #86363, we added a test.timeout arg to all go_test targets.
When generate-logictest runs out of
bazel-generate.sh,logic tests build files are re-created based on the template
that was missing the
test.timeoutarg and since the timeoutscript doesn't run, the timeouts get deleted. This patch updates
the template to include a test timeout.
Release justification: Non-production code changes
Release note: None