sql: fix COPY internal error in optimizer #87175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
cucaroach
force-pushed
the
fix-copy-crash
branch
from
34e20c4 to
f521618
Compare
Statistics builder code to evaluate distinct count had a typo and would crash if there were more rows than columns. Fix bug and rewrite to be a little clearer. Fixes: cockroachdb#87011 Release justification: low-risk high priority fix to new funcationality Release note: None
cucaroach
force-pushed
the
fix-copy-crash
branch
from
f521618 to
b431524
Compare
mgartner
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Nice find!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statistics builder code to evaluate distinct count had a typo and would
crash if there were more rows than columns. Fix bug and rewrite to be a
little clearer.
Fixes: #87011
Release justification: low-risk high priority fix to new funcationality
Release note: None