release-22.1: sql: add COPY to sampled_query logging #87091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
backport22.1-86627-86870
branch
from
91eb44d to
55a29d0
Compare
|
blathers backport 21.2 |
otan
changed the title
otan
force-pushed
the
backport22.1-86627-86870
branch
2 times, most recently
from
48d1cad to
8bf5c77
Compare
As requested by product, we want COPY to show up on sampled_query. This commit adds this, whilst fudging a few things presumably more relevant to "regular" DDL statements. Release justification: telemetry only change Release note: None
rafiss
approved these changes
Aug 30, 2022
|
do you know if the timing bug affects 22.1 also? should i backport #86991? |
Previously, we relied on the `txn` being filled to log `COPY` statements. This is however inaccurate - `txn` may be nil if `COPY` is the first statement encountered. This meant that the first COPY encountered would not be logged. Instead, plumb down `isCopy` and use `timeutil.Now()` if it is a COPY related statement. Release justification: logging related critical fix Release note: None
otan
force-pushed
the
backport22.1-86627-86870
branch
from
8bf5c77 to
c5f5d50
Compare
v22.1 is fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport (combined into one commit):
Release justification: telemetry only change
/cc @cockroachdb/release