Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix cluster_execution_insights priority level #86901

Merged
merged 1 commit into from
Aug 26, 2022
Merged

sql: fix cluster_execution_insights priority level #86901

merged 1 commit into from
Aug 26, 2022

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Aug 25, 2022

This fixes the priority level and converts it to be a string.

closes: #86900, closes #86867

Release justification: Category 2: Bug fixes and
low-risk updates to new functionality

Release note (sql change): Fix the insight
execution priority to have correct value
instead of always being default. Changed
the column to be a string to avoid
converting it in the ui.

@j82w j82w requested review from a team August 25, 2022 18:57
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I didn't realize these were always surfaced as strings. Thank you!

closes #86900, closes #86867

Release justification: Category 2: Bug fixes and
low-risk updates to new functionality

Release note (sql change): Fix the insight
execution priority to have correct value
instead of always being default. Changed
the column to be a string to avoid
converting it in the ui.
@j82w
Copy link
Contributor Author

j82w commented Aug 26, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 26, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants