Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl: drop privileges when dropping external connection #86823

Merged

Conversation

RichardJCai
Copy link
Contributor

Release justification: Bug fix to newly added feature

Release note: None

@RichardJCai RichardJCai requested review from adityamaru and a team August 24, 2022 22:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RichardJCai RichardJCai force-pushed the drop_privileges_on_drop_external_conn branch from 5a884f1 to 5287c82 Compare August 26, 2022 18:59
@RichardJCai
Copy link
Contributor Author

CI failure is from flake that is skipped on master now
Thanks for reviewing.

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Aug 26, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 27, 2022

Build failed:

Release justification: Bug fix to newly added feature

Release note: None
@RichardJCai RichardJCai force-pushed the drop_privileges_on_drop_external_conn branch from 5287c82 to ce92aac Compare August 29, 2022 15:50
@RichardJCai
Copy link
Contributor Author

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Aug 29, 2022

Build succeeded:

@craig craig bot merged commit 9da058b into cockroachdb:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants