Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: set kv.bulkio.write_metadata_sst.enabled to default false #86809

Merged
merged 1 commit into from
Aug 25, 2022
Merged

backupccl: set kv.bulkio.write_metadata_sst.enabled to default false #86809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/ccl/backupccl/backupinfo/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ go_library(
"//pkg/sql/sem/tree",
"//pkg/sql/stats",
"//pkg/storage",
"//pkg/util",
"//pkg/util/ctxgroup",
"//pkg/util/encoding",
"//pkg/util/hlc",
Expand Down
5 changes: 2 additions & 3 deletions pkg/ccl/backupccl/backupinfo/manifest_handling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgerror"
"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
"github.com/cockroachdb/cockroach/pkg/sql/stats"
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/cockroach/pkg/util/ctxgroup"
"github.com/cockroachdb/cockroach/pkg/util/encoding"
"github.com/cockroachdb/cockroach/pkg/util/hlc"
Expand Down Expand Up @@ -82,13 +83,11 @@ const (

// WriteMetadataSST controls if we write the experimental new format BACKUP
// metadata file.
// kv.bulkio.rite_metadata_sst.enabled set to false by default due to
// https://github.com/cockroachdb/cockroach/issues/85564.
var WriteMetadataSST = settings.RegisterBoolSetting(
settings.TenantWritable,
"kv.bulkio.write_metadata_sst.enabled",
"write experimental new format BACKUP metadata file",
true,
util.ConstantWithMetamorphicTestBool("write-metadata-sst", false),
)

// IsGZipped detects whether the given bytes represent GZipped data. This check
Expand Down