ttl: add queries to job details #86801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
changed the title
rafiss
force-pushed
the
ttl-job-details
branch
3 times, most recently
from
621a3f6 to
a575680
Compare
1 task
otan
approved these changes
Aug 24, 2022
rafiss
force-pushed
the
ttl-job-details
branch
2 times, most recently
from
be53392 to
2b2bce3
Compare
|
tftr! bors r=otan |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
I think there are some test failures here. bors r- |
|
Canceled. |
This helps with observability so users can understand what the TTL job is doing behind the scenes. The job details in the DB console will show: ``` ttl for defaultdb.public.t -- for each range, iterate to find rows: SELECT id FROM [108 AS tbl_name] AS OF SYSTEM TIME '30s' WHERE <crdb_internal_expiration OR ttl_expiration_expression> <= $1 AND (id) > (<range start>) AND (id) < (<range end>) ORDER BY id LIMIT <ttl_select_batch_size> -- then delete with: DELETE FROM [108 AS tbl_name] WHERE <crdb_internal_expiration OR ttl_expiration_expression> <= $1 AND (id) IN (<rows selected above>) ``` Release note: None Release justification: low risk change
rafiss
force-pushed
the
ttl-job-details
branch
from
2b2bce3 to
bc2789e
Compare
|
fixed the tests, thanks for pointing that out bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #81905
This helps with observability so users can understand what the TTL job
is doing behind the scenes.
The job details in the DB console will show:
Release note: None
Release justification: low risk change