cli: added --locality

[d4l3k]

Builds on #8627

---

This change is

[RaduBerinde]

(looked at the third commit only)

---

Review status: 0 of 38 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

roachpb/metadata.go, line 233 [r3] (raw file):

// Type returns the underlying type in string form. This is part of pflag's
// value interface.
func (l Locality) Type() string {

_ Locality

---

Comments from Reviewable

[d4l3k]

Review status: 0 of 38 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

roachpb/metadata.go, line 233 [r3] (raw file):

Previously, RaduBerinde wrote…

_ Locality

golint

roachpb/metadata.go:233:1: receiver name should not be an underscore

---

Comments from Reviewable

[RaduBerinde]

Review status: 0 of 38 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

roachpb/metadata.go, line 233 [r3] (raw file):

Previously, d4l3k (Tristan Rice) wrote…

golint

roachpb/metadata.go:233:1: receiver name should not be an underscore

Ah, my bad

---

Comments from Reviewable

[tamird]

Review status: 0 of 38 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

roachpb/metadata.go, line 233 [r3] (raw file):

Previously, RaduBerinde wrote…

Ah, my bad

It can be `func (Locality) Type() String`, though.

---

Comments from Reviewable

[d4l3k]

Review status: 0 of 38 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

roachpb/metadata.go, line 233 [r3] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

It can be func (Locality) Type() String, though.

Didn't realize that. Done.

---

Comments from Reviewable

[d4l3k]

@RaduBerinde @bdarnell Thoughts on whether I should wait to merge this until the allocator actually takes locality into account?

[bdarnell]

It's fine to merge this before it is actually used.

---

Review status: 0 of 40 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

cli/cliflags/flags.go, line 56 [r6] (raw file):

      Name: "locality",
      Description: `
An ordered, comma-separated list of key-value pairs that describe the topography

This help text should say that this is not yet fully implemented.

---

Comments from Reviewable

[d4l3k]

Review status: 0 of 40 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

---

cli/cliflags/flags.go, line 56 [r6] (raw file):

Previously, bdarnell (Ben Darnell) wrote…

This help text should say that this is not yet fully implemented.

Done.

---

Comments from Reviewable

[knz]

Seems ok to merge right?

[d4l3k]

It's being blocked on @BramGruneir's comments on #8786.

[BramGruneir]

Which comments are you waiting on? I just did another pass of it.

[d4l3k]

Bram Gruneir
Please add a number of other examples!

Tristan Rice
This info will be folded into the https://www.cockroachlabs.com/docs/configure-replication-zones.html docs. As far as I can tell, none of the other cliflags have redundant examples.

Bram Gruneir
store has a large number of examples, but we should ask @jseldess what he thinks.

Not blocked, but also have yet to respond to

Could you explain what is or what is not implemented? Or link to an issue number or something?

[BramGruneir]

Ah, I say just merge it for now. We can always add more examples.

[d4l3k]

Just added some extra examples and added a link to the tracking issue.

[BramGruneir]

That part of this change LGTM. Manitoba FTW.

---

Review status: 0 of 18 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

---

Comments from Reviewable